Include signatures with ContractTxData for calls#468
Merged
quantumagi merged 1 commit intostratisproject:masterfrom Mar 17, 2021
Merged
Include signatures with ContractTxData for calls#468quantumagi merged 1 commit intostratisproject:masterfrom
quantumagi merged 1 commit intostratisproject:masterfrom
Conversation
fassadlr
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #462 but deals with contract calls.
There is currently no way to "upgrade" contracts transparently. I.e. once e.g. a multisig-membership contract is deployed there is no easy way to fix it if problems or additional requirements are identified. I am thinking we may need something like a "system contract dictionary" system contract that allows internal processes to look up the latest contract addresses of contracts that provide specific functionality. This will make "transparent upgrades" possible and also allow contracts to be black-listed.
Of course, changing the dictionary would require multiple signatures, similar/same to the signatures required to create system contracts.