[Proposal] Show CS address in getrawtransaction output

[zeptin]

The rationale for this is in the code comments; essentially this is to improve the user experience for block explorer users trying to check their cold staking balances or staking activity.

After picking a cold staking transaction ID at random, the modified getrawtransaction output looks like this:

    {
      "value": 780.5398,
      "n": 1,
      "scriptPubKey": {
        "asm": "OP_DUP OP_HASH160 OP_ROT OP_IF OP_CHECKCOLDSTAKEVERIFY 98f869eb17b7d9ed5529bb8d139d960624ab7c39 OP_ELSE d8e6de0c675ad75f430ccbd08f3a8b0e519dc6ec OP_ENDIF OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "76a97b63b91498f869eb17b7d9ed5529bb8d139d960624ab7c396714d8e6de0c675ad75f430ccbd08f3a8b0e519dc6ec6888ac",
        "reqSigs": 1,
        "type": "coldstaking",
        "addresses": [
          "Xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
        ]
      }
    }

[quantumagi]

LGTM. My only concern is that we should probably not be showing the pubkeys that make up the cold staking script to the user as normal addresses at all - to prevent them from being used for spending funds towards. This represents a move away from that potential goal.

[zeptin]

LGTM. My only concern is that we should probably not be showing the pubkeys that make up the cold staking script to the user as normal addresses at all - to prevent them from being used for spending funds towards. This represents a move away from that potential goal.

In the interests of making as few changes at a time as possible, perhaps this should go in as-is, but we could indeed change the version byte for cold staking addresses in future. This would require changes to the cold staking controller and possibly the wallet UI too. There may be other places in the codebase that would need to be made aware of a new address type.

Either that or make the display of the addresses purely cosmetic output with no recognition of the modified addresses in the codebase. This could have its own drawbacks though, as the API/RPC would be outputting 'addresses' that it can't then give any further information about.