Show CS address in getrawtransaction output#811
Merged
fassadlr merged 1 commit intostratisproject:release/1.1.1.0from Dec 3, 2021
Merged
Show CS address in getrawtransaction output#811fassadlr merged 1 commit intostratisproject:release/1.1.1.0from
fassadlr merged 1 commit intostratisproject:release/1.1.1.0from
Conversation
quantumagi
reviewed
Dec 3, 2021
| // This may have caused user confusion, however, as the modified addresses would not look like those they used to configure the cold staking setup, making searching for them on a block explorer more difficult. | ||
| if (script.IsScriptType(ScriptType.ColdStaking)) | ||
| { | ||
| var coldPubKeyHash = new KeyId(script.ToBytes(true).SafeSubarray(28, 20)); |
Contributor
There was a problem hiding this comment.
Can this ColdStakingScriptTemplate method be used to extract this value instead?
public bool ExtractScriptPubKeyParameters(Script scriptPubKey, out KeyId hotPubKeyHash, out KeyId coldPubKeyHash)
Contributor
There was a problem hiding this comment.
@quantumagi this was previously already merged to 1.1.1.0 but I recreated the branch which caused the commit to be lost but perhaps something to note for @zeptin ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#784