Skip to content

AddressIndexer configured for unitysdk#788

Merged
noescape00 merged 6 commits intostratisproject:release/1.2.0.0from
noescape00:addrIndexerbugfix
Nov 29, 2021
Merged

AddressIndexer configured for unitysdk#788
noescape00 merged 6 commits intostratisproject:release/1.2.0.0from
noescape00:addrIndexerbugfix

Conversation

@noescape00
Copy link
Contributor

@noescape00 noescape00 commented Nov 29, 2021

Updated litedb to v5
Increased purging speed
Disabled compacting

@noescape00 noescape00 requested a review from zeptin November 29, 2021 19:06
public const int SyncBuffer = 50;

// Compaction removes info that is used by unity sdk to get UTXOs. Therefore this feature is disabled.
public const bool CompactionEnabled = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should only be false when the Unity API is being used, to preserve the previous behaviour and performance characteristics of the indexer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With compaction off behavior is the same, performance is increased, but hard drive usage is increased as well.
With compaction on cirrus test it's around 1.1gb. Currently syncing indexer, will know hard drive impact once it's done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should only be false when the Unity API is being used

address indexer is used only for unity api as far as I know.

Also once it was on it can't be turned off because it requires reindexing.

So in case compaction feature is not cosnt bool then data if it was enabled before should be persisted to the database.
I think this can be done in a separate PR once we need addr indexer for smth not unity related.

@noescape00 noescape00 merged commit af829ca into stratisproject:release/1.2.0.0 Nov 29, 2021
@quantumagi
Copy link
Contributor

@noescape00 , some tests appear to be failing following this PR.

noescape00 added a commit to noescape00/StratisFullNode that referenced this pull request Nov 30, 2021
noescape00 added a commit that referenced this pull request Nov 30, 2021
* Revert "AddressIndexer configured for unitysdk (#788)"

This reverts commit af829ca.

* added changes but without version update
noescape00 added a commit that referenced this pull request Nov 30, 2021
* Revert "AddressIndexer configured for unitysdk (#788)"

This reverts commit af829ca.

* added changes but without version update

* bugfix
rowandh pushed a commit that referenced this pull request Dec 2, 2021
* fix 1

* disable compaction

* rarer rewind purge loging

* Show error if state is incorrect

* increase purge performance

* upgraded litedb and incresed purging efficency
rowandh pushed a commit that referenced this pull request Dec 2, 2021
* Revert "AddressIndexer configured for unitysdk (#788)"

This reverts commit af829ca.

* added changes but without version update
rowandh pushed a commit that referenced this pull request Dec 2, 2021
* Revert "AddressIndexer configured for unitysdk (#788)"

This reverts commit af829ca.

* added changes but without version update

* bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants