This repository was archived by the owner on Jan 24, 2024. It is now read-only.
If all partition messages are sent, cancel the delayed tasks to avoid full gc or oom - #1745
Closed
keyboardbobo wants to merge 1 commit into
Closed
If all partition messages are sent, cancel the delayed tasks to avoid full gc or oom#1745keyboardbobo wants to merge 1 commit into
keyboardbobo wants to merge 1 commit into
Conversation
If all tasks are sent, cancel the timer tasks to avoid full gc or oom
|
|
Contributor
|
Could you sign the CLA first? |
Contributor
Author
done |
BewareMyPower
suggested changes
Mar 1, 2023
Contributor
|
BTW, could you open PRs for master branch? I see the other PR (https://github.com/streamnative/kop/pull/1747/files) is also opened for branch-2.9.2.24, but the code is different for master. |
Member
+1 |
Contributor
Author
here : #1749 |
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Apr 15, 2026
…reamnative#1749) Fixes streamnative#1745 ### Modifications increase timeout for transaction recovery test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all partition messages are sent, cancel the delayed tasks to avoid full gc or oom
Fixes #1739
Motivation
The request.timeout.ms setting is too large to cause broker full gc or oom.
Modifications
If all partition messages are sent, cancel the delayed tasks to avoid full gc or oom
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)