This repository was archived by the owner on Jan 24, 2024. It is now read-only.
If all partition messages are sent, cancel the delayed tasks to avoid full gc or oom - #1749
Merged
Merged
Conversation
If all tasks are sent, cancel the timer tasks to avoid full gc or oom
keyboardbobo
requested review from
BewareMyPower and
Demogorgon314
as code owners
March 1, 2023 09:31
keyboardbobo
changed the title
4 tasks
BewareMyPower
approved these changes
Mar 2, 2023
Demogorgon314
approved these changes
Mar 2, 2023
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
Oct 31, 2023
### Motivation streamnative#1923 removes the completion for the produce purgatory in streamnative#1749. ### Modification Added back the logic to check and complete the produce purgatory.
3 tasks
BewareMyPower
added a commit
that referenced
this pull request
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all tasks are sent, cancel the timer tasks to avoid full gc or oom
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #1739
Motivation
The request.timeout.ms setting is too large to cause broker full gc or oom.
Modifications
If all partition messages are sent, cancel the delayed tasks to avoid full gc or oom
Verifying this change
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)