This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix deadlock caused by synchronous asyncFindPosition - #556
Merged
jiazhai merged 2 commits intoJun 9, 2021
Merged
Conversation
BewareMyPower
force-pushed
the
bewaremypower/fix-find-position-deadlock
branch
from
June 8, 2021 16:53
424d369 to
b5f76bb
Compare
jiazhai
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #544
Motivation
After the debugging, when a FETCH request contains many partitions, for each partition,
KafkaTopicConsumerManager#removewill be executed in the samepulsar-io-<suffix>thread, which will eventually callMessageIdUtils#getPositionForOffsetto getPositionImplof the offset.However,
getPositionForOffsetis a synchronous method that waits until aCompletableFutureis done. The future is returned byManagedLedgerImpl#asyncFindPositionthat callsManagedLedgerImpl#asyncReadEntryinternally. If the producer is publishing messages at the same time, theasyncAddEntrymethod could be called for the sameManagedLedgerImplobject. It will somehow cause the deadlock.Modifications
ManagedLedgerImpl#asyncFindPositioninstead of the synchronous call inMessageIdUtils#getPositionForOffset.Pair<ManagedCursor, Long>in KafkaTopicConsumerManager instead of thePair<ManagedCursor, Long>. Then inMessageFetchContext, use theManagedCursorin future's callback .