WIP: GoDaddy Contributions - #47
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
* upstream/master: Update contribution guidelines test: ensure sandbox dir is present test: add `global.navigator` for browser tests test: increase timeout for browserify index: fix jshint error Conflicts: index.js
|
Hi @shelbys, thank you for the contribution. Few things to improve the next time you submit a pull request (I addressed them myself in #51 and #52 for this time):
In order to land your patch, I need you to sign our CLA first. Just follow the instructions here: https://cla.strongloop.com/agreements/strongloop/loopback-boot Note that will need the same for other repositories where you contributed pull requests too: |
|
@bajtos - We use node_modules/.bin/mocha to make it obvious that global isn't expected, and to easily copy to command-line for running single and other experiments |
|
@bajtos - Regarding CLA, GoDaddy already has a master agreement in place |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@shelbys The flow is based on the signer's GitHub credentials so we can't manually add your account. It would help us out a lot if you could click through the signing process (it's quick, I promise!) at https://cla.strongloop.com/agreements/strongloop/loopback-boot so that we don't get in the habit of ignoring CLA warnings on our PRs. |
|
@rmg - Done |
Added support for merging nested and complex data structures in configuration files in order to better support different paths across multiple environments