Support nested values in config overrides - #52
Merged
Conversation
Add more unit-tests to cover various edge cases. Fix issues discovered by these new tests.
Member
Author
|
@shelbys I need you to sign our CLA before I can land this patch. Could you please express your agreement on the following URL? https://cla.strongloop.com/agreements/strongloop/loopback-boot |
Member
Author
|
FWIW, the tests are failing on one machine only with an error not related to this patch. The other three configuration passed all tests. /cc @rmg |
Member
|
@bajtos The mkdirs error is a new transient error I'm still tracking down. There are open issues related to it on the Jenkins JIRA, but I'm not sure why they've only become a problem recently. |
Member
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Oct 9, 2014
…in-config-overrides Support nested values in config overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another follow-up PR for #47.
The first commit updates gitignore, it's best to keep these non-code changes in standalone commits.
The second commit is the original implementation as contributed by @shelbys.
The third commit builds on top of the second commit, adds more tests, fixes issues and cleans the code up.
Close #47
/to @raymondfeng please review