This repository was archived by the owner on Apr 18, 2020. It is now read-only.
gulpfile: fix nodemon settings - #10
Merged
Merged
Conversation
Remove the dependency on packages, provide sensible static configuration that works for all packages and non-packages alike. Ignore `**/test/**` files. Remove no longer used method `findSrc()`. Note: as of #7, there is no `modules/package.json`, thus the previous nodemon configuration was not picking changes made in `modules/*.js`.
Member
There was a problem hiding this comment.
I'm trying to avoid hard coding package names (eg html5) anywhere.
Member
Author
There was a problem hiding this comment.
Good point. How about */build/** instead?
Member
There was a problem hiding this comment.
I tried that initially and had issues. Maybe I had the wrong ** or pattern.
Member
Author
I agree. However, the current version of gulpfile is using hard-coded path to the app file too, so this pull request is not making the situation any worse. We can fix the
Fixed. LGTY now? |
Member
|
LGTM |
This was referenced Jun 2, 2014
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dependency on packages, provide sensible static configuration
that works for all packages and non-packages alike.
Ignore
**/test/**files.Remove no longer used method
findSrc().Note: as of #7, there is no
modules/package.json, thus the previousnodemon configuration was not picking changes made in
modules/*.js./to @ritch please review
I do realise this is dismantling the structure you have built in gulpfile. My hope is that the change is for better, as it reduces amount of code to maintain.