This repository was archived by the owner on Apr 18, 2020. It is now read-only.
Feature/buildability - #8
Merged
Merged
Conversation
Supervisor needs a main property in the package to find what to run if there is no top-level server.js or app.js.
strong-build uses a build script (if it exists) to run custom build scripts before call `npm pack`.
Not strictly necessary for strong-build, but having one is safer and more explicit. I also sorted .gitignore, to allow a simple diff of .gitignore and .npmignore to verify that build products are packed and non-build files (such as editor ephemera, test output, npm log files, etc.) are still ignored by npm.
Merged
Contributor
Author
|
/cc @bajtos |
Member
|
LGTM. If @ritch does not object by EOD Tuesday, I'll merge land this patch. |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strong-build support
/to @ritch