Skip to content
This repository was archived by the owner on Apr 18, 2020. It is now read-only.

Feature/bower build - #9

Merged
sam-github merged 2 commits into
masterfrom
feature/bower-build
Jun 6, 2014
Merged

Feature/bower build#9
sam-github merged 2 commits into
masterfrom
feature/bower-build

Conversation

@sam-github

Copy link
Copy Markdown
Contributor

Attempt to run bower at build time. Only last two commits are new, this branch is based on #8.

Needs confirmation it works from someone more familiar with how it should work. Should be able to test with

git clean -x -d
npm install
npm run build

If npm install is in good shape.

@sam-github

Copy link
Copy Markdown
Contributor Author

/cc @bajtos

Comment thread package.json Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bower install should come before gulp build, as the build depends on angular sources.

@bajtos

bajtos commented Jun 4, 2014

Copy link
Copy Markdown
Member

After I have switched the order of bower and build, the command npm run build works correctly.

@sam-github

Copy link
Copy Markdown
Contributor Author

@bajtos , thanks, I switched and packed, seems to work well, LGTY?

@bajtos

bajtos commented Jun 6, 2014

Copy link
Copy Markdown
Member

@sam-github :shipit:

@sam-github
sam-github merged commit 1c53929 into master Jun 6, 2014
@sam-github
sam-github deleted the feature/bower-build branch June 6, 2014 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants