Skip to content

Mount REST at app.restApiRoot + remove explorer basePath - #36

Merged
bajtos merged 2 commits into
masterfrom
feature/use-restApiRoot
Jan 14, 2014
Merged

Mount REST at app.restApiRoot + remove explorer basePath#36
bajtos merged 2 commits into
masterfrom
feature/use-restApiRoot

Conversation

@bajtos

@bajtos bajtos commented Jan 8, 2014

Copy link
Copy Markdown
Member
  • Mount REST API at app.get('restApiRoot')
  • Remove basePath option from loopback-explorer initialisation, as the plugin already uses app.get('restApiRoot') by default.

Requires strongloop/loopback-component-explorer#10.

/to: @ritch please review.

Miroslav Bajtoš added 2 commits January 8, 2014 09:18
Do not pass app.get('restApiRoot') as a basePath to loopback-explorer,
since the plugin is already using it as a default.
@slnode

slnode commented Jan 8, 2014

Copy link
Copy Markdown

Test PASSed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback-workspace/238/

@bajtos

bajtos commented Jan 13, 2014

Copy link
Copy Markdown
Member Author

@ritch ping.

@ritch

ritch commented Jan 13, 2014

Copy link
Copy Markdown
Member

👍

@bajtos

bajtos commented Jan 14, 2014

Copy link
Copy Markdown
Member Author

test please

@slnode

slnode commented Jan 14, 2014

Copy link
Copy Markdown

Test FAILed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback-workspace/458/

bajtos added a commit that referenced this pull request Jan 14, 2014
Mount REST at app.restApiRoot + remove explorer basePath
@bajtos
bajtos merged commit 53331cc into master Jan 14, 2014
@bajtos
bajtos deleted the feature/use-restApiRoot branch January 14, 2014 09:49
@bajtos bajtos mentioned this pull request Jan 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants