Use app.restApiRoot, emit "start" event, simplify loopback-explorer integration [DO NOT MERGE YET] - #35
Closed
bajtos wants to merge 3 commits into
Closed
Conversation
|
Test FAILed. To trigger a build add comment - ".test\W+please" |
Member
|
LGTM |
Member
|
FYI, our CI would be able to build these cross-repo changes together if the repos all used the same branch name. |
added 3 commits
January 8, 2014 09:01
When loopback-explorer is not installed, the info message is printed directly form the `catch` block. When loopback-explorer was found, we let the module handle any logging via the "start" event.
|
Test PASSed. To trigger a build add comment - ".test\W+please" |
Member
Author
|
Closing in favour of #36. The logging at start turned out to be more complex than I initially thought, I will address it in a standalone PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on strongloop/loopback#123.
Requires strongloop/loopback-component-explorer#9.
We need to bump up the loopback version in templates/package.js before merging the patch.
/to: @ritch please review
/cc: @sam-github