Skip to content
This repository was archived by the owner on May 9, 2020. It is now read-only.

Bug 1508383 - pass TASKCLUSTER_{ROOT,PROXY}_URL to tasks#418

Merged
walac merged 4 commits intotaskcluster:masterfrom
djmitche:bug1508383
Dec 28, 2018
Merged

Bug 1508383 - pass TASKCLUSTER_{ROOT,PROXY}_URL to tasks#418
walac merged 4 commits intotaskcluster:masterfrom
djmitche:bug1508383

Conversation

@djmitche
Copy link
Copy Markdown
Contributor

@djmitche djmitche self-assigned this Nov 19, 2018
@djmitche djmitche requested a review from walac November 19, 2018 22:04
@walac
Copy link
Copy Markdown
Contributor

walac commented Nov 20, 2018

It feels like there is a regression

@djmitche djmitche removed the request for review from walac November 20, 2018 19:50
@djmitche
Copy link
Copy Markdown
Contributor Author

Looking now..

@djmitche
Copy link
Copy Markdown
Contributor Author

Ah, I think it's because taskcluster/taskcluster-proxy#38 hasn't landed yet, so when it starts taskcluster-proxy, the proxy bails because it doesn't understand --root-url. Let's wait until that PR lands.

@djmitche
Copy link
Copy Markdown
Contributor Author

OK, upgraded to the just-released 5.0.0 from taskcluster/taskcluster-proxy#38. Let's see what the tests do..

@djmitche
Copy link
Copy Markdown
Contributor Author

OK that's probably my fault:

    1) issue a request to taskcluster via the proxy
  29 passing (9m)
  1 failing
  1) taskcluster proxy issue a request to taskcluster via the proxy:
     AssertionError [ERR_ASSERTION]: custom artifact is available
      at Context.test (test/integration/taskcluster_proxy_test.js:45:12)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

@djmitche djmitche removed the request for review from walac December 26, 2018 20:24
@djmitche
Copy link
Copy Markdown
Contributor Author

OK, relatively simple fix, but please let me know if you agree with the plan in https://bugzilla.mozilla.org/show_bug.cgi?id=1508383#c2 that it represents.

@djmitche djmitche requested a review from walac December 27, 2018 16:28
@walac walac merged commit 9dbb6d7 into taskcluster:master Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants