This repository was archived by the owner on May 9, 2020. It is now read-only.
Bug 1508383 - pass TASKCLUSTER_{ROOT,PROXY}_URL to tasks#418
Merged
walac merged 4 commits intotaskcluster:masterfrom Dec 28, 2018
Merged
Bug 1508383 - pass TASKCLUSTER_{ROOT,PROXY}_URL to tasks#418walac merged 4 commits intotaskcluster:masterfrom
walac merged 4 commits intotaskcluster:masterfrom
Conversation
Contributor
|
It feels like there is a regression |
Contributor
Author
|
Looking now.. |
Contributor
Author
|
Ah, I think it's because taskcluster/taskcluster-proxy#38 hasn't landed yet, so when it starts taskcluster-proxy, the proxy bails because it doesn't understand |
Contributor
Author
|
OK, upgraded to the just-released 5.0.0 from taskcluster/taskcluster-proxy#38. Let's see what the tests do.. |
Contributor
Author
|
OK that's probably my fault: |
Contributor
Author
|
OK, relatively simple fix, but please let me know if you agree with the plan in https://bugzilla.mozilla.org/show_bug.cgi?id=1508383#c2 that it represents. |
walac
approved these changes
Dec 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per taskcluster/taskcluster-rfcs#128