Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Bug 1460015 - add rootUrl support#38

Merged
djmitche merged 6 commits intotaskcluster:masterfrom
djmitche:bug1460015
Dec 26, 2018
Merged

Bug 1460015 - add rootUrl support#38
djmitche merged 6 commits intotaskcluster:masterfrom
djmitche:bug1460015

Conversation

@djmitche
Copy link
Copy Markdown
Contributor

See the individual commits. This should be 100% backward compatible. Note that bewits won't work for anything but https://taskcluster.net until the client is updated, but that's probably fine.

@djmitche djmitche self-assigned this Nov 19, 2018
@djmitche djmitche requested a review from petemoore November 19, 2018 23:12
@djmitche
Copy link
Copy Markdown
Contributor Author

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1508447 for the bewit fix.

@djmitche
Copy link
Copy Markdown
Contributor Author

Ah, the Travis run is failing because this is a PR from another and it doesn't have access to TASKCLUSTER_ACCESS_TOKEN.

@djmitche
Copy link
Copy Markdown
Contributor Author

Refactored to use a separate handler.

@djmitche djmitche requested review from walac and removed request for petemoore December 25, 2018 14:27
@djmitche djmitche merged commit df4cb32 into taskcluster:master Dec 26, 2018
@djmitche
Copy link
Copy Markdown
Contributor Author

Released as v5.0.0

@petemoore
Copy link
Copy Markdown
Member

This PR didn't handle /api/... urls correctly; fixed in #40.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants