Skip to content

Webgpu feature scatter nd#5643

Merged
qjia7 merged 3 commits intotensorflow:masterfrom
haoyunfeix:webgpu_feature_scatter_nd
Sep 24, 2021
Merged

Webgpu feature scatter nd#5643
qjia7 merged 3 commits intotensorflow:masterfrom
haoyunfeix:webgpu_feature_scatter_nd

Conversation

@haoyunfeix
Copy link
Contributor

@haoyunfeix haoyunfeix commented Sep 20, 2021

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Sep 20, 2021
@rthadur rthadur requested a review from pyu10055 September 20, 2021 16:46
@haoyunfeix
Copy link
Contributor Author

@qjia7 @axinging @xhcao @gyagp, PTAL

Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it should be merged after #5629 since it depends on ScatterProgram.

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@haoyunfeix haoyunfeix force-pushed the webgpu_feature_scatter_nd branch from c274b5e to b8d2f5a Compare September 24, 2021 10:32
@qjia7 qjia7 merged commit d8a8afe into tensorflow:master Sep 24, 2021
pyu10055 pushed a commit that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants