Skip to content

deps: Upgrade to dbal v3#12

Merged
moufmouf merged 2 commits into
thecodingmachine:masterfrom
aszenz:master
Jan 27, 2024
Merged

deps: Upgrade to dbal v3#12
moufmouf merged 2 commits into
thecodingmachine:masterfrom
aszenz:master

Conversation

@aszenz

@aszenz aszenz commented Jan 27, 2024

Copy link
Copy Markdown
Contributor

Upgraded the package to use dbal v3

It will be a breaking change and require releasing a new major version.

My overall goal is to make https://github.com/thecodingmachine/tdbm work on dbal 3.

@aszenz

aszenz commented Jan 27, 2024

Copy link
Copy Markdown
Contributor Author

@moufmouf Once this is merged I could work on making https://github.com/thecodingmachine/tdbm-fluid-schema-builder work with dbal 3

@moufmouf

Copy link
Copy Markdown
Member

Absolutely excellent!

Technically, I think I could tag only a minor since the API of the library itself is not changing.

Composer should take care of the dependencies and as long as someone is not relying on the DBAL transitive dependency (which can be detected with https://github.com/maglnet/ComposerRequireChecker) and is correctly also adding DBAL in the require if they are using DBAL directly, we should be good.

@moufmouf

Copy link
Copy Markdown
Member

Wait, I'm wrong, I need to tag a major because of $column->getDbalColumn() that exposes the DBAL type (that changed) to the outer world. Let's tag a 2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants