xrCore: rt_compressor.cpp: Use appropriate integer type#10
Merged
themrdemonized merged 1 commit intothemrdemonized:all-in-one-vs2022from Aug 15, 2023
Conversation
* rtc_compress, rtc_decompress: Both of these functions pass a pointer
to an out_size variable which lzo1x_1_compress and lzo1x_1_decompress
dereference to store the value for the caller to use. The problem is
that with a u32 type it's passing a pointer to a 4-byte integer but
cast as an 8-byte integer hence the dereference and store is unsafe.
*out_len = 0;
00000001405064F6 mov rax,qword ptr [out_len]
00000001405064FE mov qword ptr [rsp+58h],rax
0000000140506503 mov rcx,qword ptr [rsp+58h]
0000000140506508 call __asan_store8 (014355B111h)
000000014050650D mov rax,qword ptr [out_len]
0000000140506515 mov qword ptr [rax],0 <----- *qword*
Found with address sanitizer.
themrdemonized
added a commit
that referenced
this pull request
Aug 15, 2023
xrCore: rt_compressor.cpp: Use appropriate integer type (cherry picked from commit fa77274)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with address sanitizer.