Skip to content

xrCore: rt_compressor.cpp: Use appropriate integer type #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themrdemonized merged 1 commit into from
Aug 15, 2023
Merged

xrCore: rt_compressor.cpp: Use appropriate integer type #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
xrCore: rt_compressor.cpp: Use appropriate integer type 
* rtc_compress, rtc_decompress: Both of these functions pass a pointer
  to an out_size variable which lzo1x_1_compress and lzo1x_1_decompress
  dereference to store the value for the caller to use. The problem is
  that with a u32 type it's passing a pointer to a 4-byte integer but
  cast as an 8-byte integer hence the dereference and store is unsafe.

    *out_len = 0;
00000001405064F6  mov         rax,qword ptr [out_len]
00000001405064FE  mov         qword ptr [rsp+58h],rax
0000000140506503  mov         rcx,qword ptr [rsp+58h]
0000000140506508  call        __asan_store8 (014355B111h)
000000014050650D  mov         rax,qword ptr [out_len]
0000000140506515  mov         qword ptr [rax],0 <----- *qword*

  Found with address sanitizer.
  • Loading branch information
@clayne
clayne committed Aug 14, 2023
commit a131fb84946545ba18efeb693f580a2d9e3fcded
4 changes: 2 additions & 2 deletions src/xrCore/rt_compressor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ u32 rtc_csize(u32 in)

u32 rtc_compress(void* dst, u32 dst_len, const void* src, u32 src_len)
{
u32 out_size = dst_len;
lzo_uint out_size = dst_len;
int r = lzo1x_1_compress(
(const lzo_byte*)src, (lzo_uint)src_len,
(lzo_byte*)dst, (lzo_uintp)&out_size,
Expand All @@ -36,7 +36,7 @@ u32 rtc_compress(void* dst, u32 dst_len, const void* src, u32 src_len)

u32 rtc_decompress(void* dst, u32 dst_len, const void* src, u32 src_len)
{
u32 out_size = dst_len;
lzo_uint out_size = dst_len;
int r = lzo1x_decompress(
(const lzo_byte*)src, (lzo_uint)src_len,
(lzo_byte*)dst, (lzo_uintp)&out_size,
Expand Down