Crosshair Sizing Fixes Again#210
Merged
themrdemonized merged 3 commits intothemrdemonized:landerfrom May 3, 2025
Merged
Conversation
- Switched to a pixel-based metric instead of a screen-based one - Proper use of projected W for depth-inverse scaling - Refactored vertex drawing logic into reusable code - Introduced g_crosshair_depth_* commands to control scaling range - Adjusted default crosshair sizing params to account for changes in metric
- Avoids edge-cases in rasterization coverage at size 1
Closed
Owner
|
Please make changes to the current PR related to the problem instead of creating new PR, it will ease the life for both of us. Mark the PR as draft if its not ready to be merged |
Contributor
Author
|
Noted - is that possible with a PR that's already been merged? I assumed not, but if so then I'll target the base branch if the suboptimal situation of after-the-fact bugs comes up in future. And apologies for the last-minute epsilon amend; that was a shower thought that occurred while away from the machine after the fact. |
Owner
|
Make a new PR and that will be your new changes base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crosshair sizing was inaccurate to vanilla, so has been switched to a pixel-based metric to ensure proper 3x3 display independent of resolution and FOV. New commands have been added to control near/far scaling range, and the default distance metrics have been modified accordingly.
It was also incorrectly applying crosshair roll when
g_fireposwas turned off, which is now gated by a conditional.