Skip to content

3D Ballistics Fixes #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themrdemonized merged 11 commits into from
Jun 20, 2025
Merged

3D Ballistics Fixes #259

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7d7db78
Fire knife from camera
ProfLander Jun 17, 2025
57a1d95
Make `aimpos` authoritative over crosshair rotation
ProfLander Jun 17, 2025
5e83833
Remove redundant `aimpos` handling from `CHudManager`
ProfLander Jun 17, 2025
9a50f5f
Simplify `CActor::GetPick` implementation
ProfLander Jun 17, 2025
925446e
Apply weapon or device fire params, not both
ProfLander Jun 18, 2025
27709d0
Make weapon authoritative over firepos / aimpos
ProfLander Jun 18, 2025
305c7d5
Third-person firepos improvements
ProfLander Jun 18, 2025
5cc8a34
Fix incorrect `g_get_target_pos` output during weapon wall penetration
ProfLander Jun 18, 2025
af19565
Respect firepos and aimpos in `CHudItem`, per-crosshair settings outs…
ProfLander Jun 18, 2025
293d458
Set default weapon / device far crosshair size to 1
ProfLander Jun 18, 2025
61d95cb
Properly categorize non-weapon main hand items when drawing crosshairs
ProfLander Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant aimpos handling from CHudManager
  • Loading branch information
@ProfLander
ProfLander committed Jun 17, 2025
commit 5e838336f044307d9b5d595ddd1a57b4d8d43282
35 changes: 0 additions & 35 deletions src/xrGame/HUDManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,42 +164,7 @@ void CHUDManager::OnFrame()
pUIGame->OnFrame();

PP.CameraPick();

g_player_hud->OnFrame();

// If aim position is enabled...
if (!FireposActive() && AimposActive())
{
// And we have a valid actor...
CActor* pActor = Actor();
if (pActor)
{
// And a valid HUD item...
PIItem pItem = pActor->inventory().ActiveItem();
if (pItem)
{
CHudItem* pHudItem = pItem->cast_hud_item();
if (pHudItem)
{
attachable_hud_item* hi = pHudItem->HudItemData();
if (hi)
{
// Ensure the HUD item's transform is valid
hud_item_measures measures = hi->m_measures;
Fmatrix matrix = hi->m_item_transform;
if (matrix.k.square_magnitude() > 0.0)
{
// Aim along barrel rotation
matrix.mulB_43(hi->m_model->LL_GetTransform(measures.m_fire_bone));
matrix.mulB_43(Fmatrix().translate(measures.m_fire_point_offset));
PP.defs.dir = matrix.k;
}
}
}
}
}
}

DoPick(PP);
}

Expand Down