Skip to content

sof-soundwire: split speaker configuration for 2 and 4ch cases - #34

Merged
plbossart merged 1 commit into
thesofproject:masterfrom
plbossart:fix/4ch-configs
May 1, 2020
Merged

sof-soundwire: split speaker configuration for 2 and 4ch cases#34
plbossart merged 1 commit into
thesofproject:masterfrom
plbossart:fix/4ch-configs

Conversation

@plbossart

Copy link
Copy Markdown
Member

Add tests and separate files for configurations

Fixes: thesofproject/linux#1998

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@plbossart

Copy link
Copy Markdown
Member Author

@RanderWang I could use some help to figure out how to deal with the TGL 2-amp case. we may need a cfg-amp:<1/2/4> string to represent all possible topologies?

@RanderWang

Copy link
Copy Markdown

@plbossart yes, we can judge amp number by spk number now. I discussed with @bardliao, for static configured codec amp number can be derived from spk number. But for some codecs can be configured dynamically to support different number of spk, cfg-spk doesn't work. We can add cfg-amp in machine driver when we get this dynamic configuration or do it now ?

@plbossart

Copy link
Copy Markdown
Member Author

@plbossart yes, we can judge amp number by spk number now. I discussed with @bardliao, for static configured codec amp number can be derived from spk number. But for some codecs can be configured dynamically to support different number of spk, cfg-spk doesn't work. We can add cfg-amp in machine driver when we get this dynamic configuration or do it now ?

I think it's better to add this now, and use it later. Do you want to send a PR for the machine driver?

@RanderWang

Copy link
Copy Markdown

@plbossart yes, we can judge amp number by spk number now. I discussed with @bardliao, for static configured codec amp number can be derived from spk number. But for some codecs can be configured dynamically to support different number of spk, cfg-spk doesn't work. We can add cfg-amp in machine driver when we get this dynamic configuration or do it now ?

I think it's better to add this now, and use it later. Do you want to send a PR for the machine driver?

yes , thesofproject/linux#2006

@libinyang

Copy link
Copy Markdown

@plbossart As we have supported RT1308-2 in this patch, we should use RT1308.conf instead of RT1308-1.conf in HiFi.conf

@plbossart

Copy link
Copy Markdown
Member Author

@plbossart As we have supported RT1308-2 in this patch, we should use RT1308.conf instead of RT1308-1.conf in HiFi.conf

Sorry I don't understand this remark.

@libinyang

Copy link
Copy Markdown

Sorry I don't understand this remark.

@plbossart I mean in HiFi.conf,

<sof-soundwire/RT700.conf>
<sof-soundwire/RT711.conf>
<sof-soundwire/RT5682.conf>
- <sof-soundwire/RT1308-1.conf>
<sof-soundwire/RT715.conf>
<sof-soundwire/Hdmi.conf>

should be

<sof-soundwire/RT700.conf>
<sof-soundwire/RT711.conf>
<sof-soundwire/RT5682.conf>
+ <sof-soundwire/RT1308.conf>
<sof-soundwire/RT715.conf>
<sof-soundwire/Hdmi.conf>

Now. Maybe this should also be updated in this PR.

Add tests and separate files for configurations

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart

Copy link
Copy Markdown
Member Author

fixed errors reported by @libinyang let's merge and submit PRs against this if it's broken.

@plbossart
plbossart merged commit 12743d2 into thesofproject:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SDW UCM2][BUG][CML-H]Left and Right speaker can't be separated when do speaker test 0,2.

3 participants