ASoC: Intel: sof_sdw: add amp number in components string for ucm - #2006
Merged
Conversation
RanderWang
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
April 10, 2020 06:40
bardliao
previously approved these changes
Apr 10, 2020
bardliao
left a comment
bardliao
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @RanderWang LGTM.
Member
|
@RanderWang do we actually need to add a quirk? |
RanderWang
force-pushed
the
cfg-amp
branch
2 times, most recently
from
April 13, 2020 05:57
f67603c to
3a4da45
Compare
Author
yes, good idea! Update my PR, thanks! |
plbossart
requested changes
Apr 13, 2020
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
minor nit-pick on the commit message - but good otherwise
The number of speaker amplifiers may vary between platforms. Ucm needs to check amp number to include different configuration files. This patch keeps track of the number of speaker amplifiers and stores it in components string of the card. Tested on Comet Lake platforms. Signed-off-by: randerwang <rander.wang@linux.intel.com>
RanderWang
changed the title
Author
|
@plbossart thanks, update my comments. |
lyakh
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of amp codec is different on each sdw platform. Ucm
needs to check amp number to include different config file.
Signed-off-by: randerwang rander.wang@linux.intel.com