topology2: Add instance attribute for all classes - #6986
Conversation
e20458b to
90e2a60
Compare
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
Looks consistent and I think I even have an idea why this is needed, but I have trouble building the typologies from this PR. I even updated my alsa-utils and run west update, but build-tools.sh -T still fails:
- cmake --build /home/oku/work/sof-zephyr/sof/tools/build_tools -- -j 28 topologies
[0/24] Generating cavs-sdw.tplg
ALSA lib pre-process-object.c:1397:(tplg_construct_object_name) Argument name not set for object 'manifest.sof_manifest'
ALSA lib pre-process-object.c:1715:(tplg_build_object) Failed to construct object name for sof_manifest
ALSA lib pre-process-object.c:1885:(tplg_pre_process_objects) Error building object Base.manifest.sof_manifest
Unable to pre-process configuration
FAILED: topology/topology2/avs-tplg/cavs-sdw.tplg
@jsarha you dont need any alsautils changes with this PR and the tools build is passing in the PR. Are you sure you dont have any local manual changes that are breaking your build? |
|
@jsarha this PR builds for me at least. |
In preparation for making it easier to write topology conf files that
can be conditionally included without having to worry about conflicting
node ID's for objects between the included file and the top-level conf
file, modify all classes to include an instance attribute. This means
that irrespective of the object type, all objects will be instantiated
as follows:
Object.Widget.gain.1 {} or Object.Base.pdm_config.2 {} etc
The instance ID's are typically only meant for the alsatplg compiler to
differentiate the nodes in the conf file and are not relevant for the
kernel or the firmware. This change will allow the alsatplg compiler to
be modified to automatically make the node ID's unique before
conditionally including conf files.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
90e2a60 to
cbd0074
Compare
|
I can build tools and topologies with the SOF docker image. |
|
SOFCI TEST |
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
Compile problem was just a user error. Fixed with git clean -xdf.
|
All the daily tests started failing on MTLP_RVP_NOCODEC today with SOF commit ae8ca22, internal test run 20201. This PR is the only change between these two commits. There was no kernel change. There's no reproduction and bug filed yet but this is an early heads-up that this PR is the prime suspect for now. |
That's wrong sorry. There was also |
|
False alarm, sorry for the noise. Daily tests landed on a faulty device (internal issue 355) |
6 participants
In preparation for making it easier to write topology conf files that can be conditionally included without having to worry about conflicting node ID's for objects between the included file and the top-level conf file, modify all classes to include an instance attribute. This means that irrespective of the object type, all objects will be instantiated as follows:
Object.Widget.gain.1 {} or Object.Base.pdm_config.2 {} etc
The instance ID's are typically only meant for the alsatplg compiler to differentiate the nodes in the conf file and are not relevant for the kernel or the firmware. This change will allow the alsatplg compiler to be modified to automatically make the node ID's unique before conditionally including conf files.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com