topology2: Build the topology for MTL chromebook - #6987
Merged
Merged
Conversation
RDharageswari
requested review from
aborisovich,
dbaluta,
lbetlej,
lgirdwood,
marc-hb,
mmaka1 and
plbossart
as code owners
January 23, 2023 21:26
plbossart
reviewed
Jan 23, 2023
marc-hb
removed their request for review
January 23, 2023 22:26
RDharageswari
force-pushed
the
23_01
branch
3 times, most recently
from
January 24, 2023 01:51
85ceed5 to
d7c4e61
Compare
Add variable definitions for all HS and Speaker settings such as codec name, SSP DAI index, PCM caps names etc in preparation to make this file reusable for variations in the SSP ports in different machines. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Dharageswari R <dharageswari.r@intel.com>
Build the topology for the MTL chromebook with Headset on SSP 2 and speakers on SSP 0. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Dharageswari R <dharageswari.r@intel.com>
ranj063
approved these changes
Jan 24, 2023
plbossart
approved these changes
Jan 24, 2023
| "cavs-rt5682\;sof-mtl-max98357a-rt5682-ssp2-ssp0\;PLATFORM=mtl,NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,\ | ||
| PDM1_MIC_B_ENABLE=1,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-max98357a-rt5682.bin,\ | ||
| DEEPBUFFER_FW_DMA_MS=10,HEADSET_SSP_DAI_INDEX=2,SPEAKER_SSP_DAI_INDEX=0,HEADSET_CODEC_NAME=SSP2-Codec,\ | ||
| SPEAKER_CODEC_NAME=SSP0-Codec" |
Member
There was a problem hiding this comment.
the only nit-pick I would have is that the information is duplicated with HEADSET_SSP_DAI_INDEX=2 and HEADSET_CODEC_NAME=SSP2-Codec
If you need to change that's 2 variables instead of a single value.
This can be fixed as an improvement, it's good enough for now.
Collaborator
There was a problem hiding this comment.
@plbossart that feature is coming. @jsarha is working on a string concat feature that will allow us to do this.
jsarha
approved these changes
Jan 25, 2023
jsarha
left a comment
jsarha
left a comment
Contributor
There was a problem hiding this comment.
Finally a topology PR I can understand fully on the first read. Approved with a minor nitpick.
|
|
||
| Object.Widget.copier.1 { | ||
| stream_name 'SSP0 Playback' | ||
| stream_name '$HEADSET_PLAYBACK_PCM_STREAM_NAME' |
Contributor
There was a problem hiding this comment.
A minor nitpick: Wouldn't it be cleaner to have one commit to introduce the stream name variable and another to change the name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the topology for the MTL chromebook with Headset on SSP 2 and speakers on SSP 0.