Use TinyGo __app_ram_base#3
Closed
aykevl wants to merge 1 commit into
Closed
Conversation
aykevl
force-pushed
the
master
branch
6 times, most recently
from
3a84858 to
c26709f
Compare
This makes sure the SoftDevice start address is configured in only one place, and thus avoid potential issues when it is changed. It also will allow setting a different SoftDevice RAM size with a linker flag, in LLVM 11 (when expressions are allowed in the MEMORY part of a linker script).
Member
|
Looks like this branch needs merge conflict resolution, please. |
Member
Author
|
Rereading the code I saw a bug, will fix it eventually (there isn't any hurry, and it'll break the last stable TinyGo release). |
Member
|
Is this PR still valid? |
Member
Author
|
This change is included in #61, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure the SoftDevice start address is configured in only one
place, and thus avoid potential issues when it is changed. It also will
allow setting a different SoftDevice RAM size with a linker flag, in
LLVM 11 (when expressions are allowed in the MEMORY part of a linker
script).