nrf: add support for S113 SoftDevice #61
Merged
Merged
Conversation
Not using the right signature led to a compiler crash. The compiler should probably be fixed in this case (to report an error instead), but this at least fixes the issue.
This makes sure the SoftDevice start address is configured in only one place, and thus avoid potential issues when it is changed. It also will allow setting a different SoftDevice RAM size with a linker flag starting with LLVM 11 (when expressions are allowed in the MEMORY part of a linker script).
This SoftDevice is used by default on the BBC micro:bit v2 so it's a good idea to add support here. Unfortunately this SoftDevice does not support scanning and connecting to other devices. This means that I unfortunately had to duplicate the event handler. I managed to refactor most other code to avoid duplicating much more. (This is when macros would have been useful in Go...)
Closed
Member
|
Thank you @aykevl this is great progress! Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This SoftDevice is used by default on the BBC micro:bit v2 so it's a good idea to add support here.
Unfortunately this SoftDevice does not support scanning and connecting to other devices. This means that I unfortunately had to duplicate a significant chunk of code. (This is when macros would have been useful in Go...)
This depends on tinygo-org/tinygo#1800 to get the CI to pass.