Add Block elements from the Symbols for Legacy Computing#1566
Closed
joshka wants to merge 6 commits intotonsky:masterfrom
Closed
Add Block elements from the Symbols for Legacy Computing#1566joshka wants to merge 6 commits intotonsky:masterfrom
joshka wants to merge 6 commits intotonsky:masterfrom
Conversation
Contributor
Author
|
Reading a little more, I think I might have messed up the production names changing them to uni12345 instead of u12345 at least according to https://glyphsapp.com/learn/getting-your-glyph-names-right |
tonsky
added a commit
that referenced
this pull request
Jan 2, 2024
tonsky
added a commit
that referenced
this pull request
Jan 2, 2024
Owner
|
Thanks! Merged I agree working with .glyphs format is a pain :( Not git-friendly at all |
2 tasks
Contributor
Author
Closing out as merged in the related commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1FB70 to 1FB8B inclusive (28 glyphs of 212 total in the block)
This is my first font editing experience, so I'm sure I've probably messed something up. In particular, I think at least one of the glyphs I duplicated and edited the original rather than the duplicate. I think this explains the removals in the diff
Issues I ran into (notes for others following a similar path):
git clean -fgot me past the problem though.