Feature/https redirect#185
Merged
Michael Vittrup Larsen (michaelvl) merged 1 commit intomainfrom Jun 1, 2023
Merged
Conversation
Michael Vittrup Larsen (michaelvl)
requested review from
Sebastian Kalita (kuketro) and
Martin Villumsen (mvillumsen)
as code owners
Merged
3 tasks
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/https-redirect
branch
from
decc8c7 to
0ef077a
Compare
Sebastian Kalita (kuketro)
approved these changes
May 31, 2023
Michael Vittrup Larsen (michaelvl)
force-pushed
the
feature/https-redirect
branch
from
0ef077a to
c52469c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR Adds redirects from HTTP to HTTPS.
The blueprint previously alloved the HTTPS port to be configured and had a default of 443. With this PR, this feature have been removed. Now redirect from port 80 to 443 and TLS termination on port 443 is hardcoded.
Fixes #154