Fix empty status message. Rename Resource field#215
Merged
Michael Vittrup Larsen (michaelvl) merged 2 commits intomainfrom Jul 7, 2023
Merged
Fix empty status message. Rename Resource field#215Michael Vittrup Larsen (michaelvl) merged 2 commits intomainfrom
Michael Vittrup Larsen (michaelvl) merged 2 commits intomainfrom
Conversation
Michael Vittrup Larsen (michaelvl)
requested review from
Sebastian Kalita (kuketro) and
Martin Villumsen (mvillumsen)
as code owners
Michael Vittrup Larsen (michaelvl)
force-pushed
the
fix/213-empty-status-message
branch
from
5ea8512 to
5681bf2
Compare
Michael Vittrup Larsen (michaelvl)
deleted the
fix/213-empty-status-message
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A common situation where the status message was empty were in the case of template rendering errors. The previous version of the code did not handle this - it only handled apply errrors, i.e. errors encountered after a succesfull rendering.
This PR also implements a FIXME, the renaming of the
NewResourcestoResourcesin theResourceTemplateStatestruct.Fixes #213
Checklist