add native build - #376
Conversation
|
looks like you need to run |
|
follow up #384 |
* checkpoint with compiling * refactor merging * use DefiniteString more * try to fix tests * get 3.0.2 passing * fix mima, improve oneOf * checkpoint * get tests passing * more tests, format, mima * remove unused code * simplify isVoided * cleanup * add isUnit * address review comments * add non-voided stringIn benchmarks
* Update sbt-typelevel to 0.4.6 * Run prePR with sbt-typelevel
dda5375 to
80ab15c
Compare
|
Hmm, cats-core_native2.11 is not published...🤔 |
|
can you disable the native build for 2.11? |
|
Yes, of course :) |
|
@i10416 thanks for the heads-up! If you're interested, the plan is to integrate that with sbt-typelevel in typelevel/sbt-typelevel#138. |
|
@i10416 I'd like to publish the next version soon. Do you want to try to get the native build ready to be in that release? |
|
@johnynek I am not in a hurry, so feel free to publish the next release😉 I think(or hope) Scala 3.1.2 will be available until the one after the next cats-parse release and I will finish this PR until then. |
|
@armanbilge Thanks! I will take a look at the linked issue. |
|
Actually, I think we should forget about Scala 3.0 and update everything to Scala 3.1. Lots of folks seem to agree, including the munit maintainers. Then we don't need to wait for Scala 3.1.2. See: |
|
@armanbilge Btw, I'm a bit busy in April and progress may delay. |
Codecov Report
@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 95.06% 95.14% +0.07%
==========================================
Files 9 9
Lines 1338 1338
Branches 124 124
==========================================
+ Hits 1272 1273 +1
+ Misses 66 65 -1
Continue to review full report at Codecov.
|
459f5cf to
bc79463
Compare
cats-parse for scala 2.12 scala native is not released
3b537bb to
8d9a790
Compare
8d9a790 to
33adb06
Compare
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
2408e18 to
18065c8
Compare
| resolvers ++= Seq( | ||
| "Sonatype OSS Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots", | ||
| "Sonatype OSS Snapshots s01" at "https://s01.oss.sonatype.org/content/repositories/snapshots" | ||
| ), | ||
| crossScalaVersions := (ThisBuild / crossScalaVersions).value.filterNot(_.startsWith("2.11")), | ||
| tlVersionIntroduced := List("2.12", "2.13", "3").map(_ -> "0.3.8").toMap, | ||
| libraryDependencies := { | ||
| if (scalaVersion.value.startsWith("3.1")) { | ||
| libraryDependencies.value.filterNot(_ == Dependencies.cats) ++ Seq( | ||
| Dependencies.catsSnapshot.value | ||
| ) | ||
| } else { libraryDependencies.value } | ||
| }, |
There was a problem hiding this comment.
6 participants
close #371
Waiting for non-snapshot cats-core_native0.4_3 published
which depends onsupport scala-native Scala 3 build scalacheck#868and test dependencies for native 3.x, which depends on
support scala-native Scala 3 build scalacheck#868Cross publish native scalameta/munit#477and they are waiting for the compiler flag to be introduced in Scala 3.1.2.Now, cats(snapshot version) supports Scala Native x Scala 3