Skip to content

Upgrade scalacheck-effect to 1.0.3 - #2661

Merged
mpilquist merged 2 commits into
typelevel:mainfrom
mpilquist:topic/upgrade-scalacheck-effect
Oct 6, 2021
Merged

Upgrade scalacheck-effect to 1.0.3#2661
mpilquist merged 2 commits into
typelevel:mainfrom
mpilquist:topic/upgrade-scalacheck-effect

Conversation

@mpilquist

Copy link
Copy Markdown
Member

No description provided.

@vasilmkd

vasilmkd commented Oct 3, 2021

Copy link
Copy Markdown
Member

This seems to have locked up the CI.

@mpilquist

Copy link
Copy Markdown
Member Author

Based on running locally, it appears that ioJS tests hang:

sbt:fs2-io> test
[warn] javaOptions will be ignored, fork is set to false
fs2.io.file.FilesSuite:
  + readAll - retrieves whole content of a file 0.06s
  + readAll - suspends errors in the effect 0.01s
  + readRange - reads half of a file 0.02s
  + readRange - reads full file if end is bigger than file size 0.02s
  + writeAll - simple write 0.02s
  + writeAll - append 0.02s
  + writeAll - suspends errors in the effect 0.00s
  + tail - keeps reading a file as it is appended 1.02s
  + exists - returns false on a non existent file 0.00s
  + exists - returns true on an existing file 0.00s
  + permissions - should fail for a non existent file 0.00s
  + permissions - should return permissions for existing file 0.00s
  + permissions - innappropriate access should raise AccessDeniedException 0.01s
  + setPermissions - should fail for a non existent file 0.01s
  + setPermissions - should correctly change file permissions for existing file 0.01s
  + copy - returns a path to the new file 0.00s
  + delete - should fail on a non existent file 0.00s
  + delete - should fail on a non empty directory 0.01s
  + deleteIfExists - should result in non existent file 0.00s
  + deleteDirectoryRecursively - should remove a non-empty directory 0.00s
  + move - should result in the old path being deleted 0.00s
  + size - should return correct size of ay file 0.01s
  + tempFile - should remove the file following stream closure 0.00s
  + tempFile - should not fail if the file is deleted before the stream completes 0.00s
  + tempFile - should create the file in the specified directory 0.00s
  + tempFile - should create the file in the default temp directory when dir is not specified 0.00s
  + tempDirectoryStream - should remove the directory following stream closure 0.00s
  + tempDirectoryStream - should not fail if the directory is deleted before the stream completes 0.00s
  + tempDirectoryStream - should create the directory in the specified directory 0.00s
  + tempDirectoryStream - should create the directory in the default temp directory when dir is not specified 0.00s
  + createDirectory - should return in an existing path 0.00s
  + createDirectories - should return in an existing path 0.00s
  + list - returns an empty Stream on an empty directory 0.01s
  + list - returns all files in a directory correctly 0.01s
  + list - fail for non-directory 0.00s
  + walk - returns the only file in a directory correctly 0.01s
  + walk - returns all files in a directory correctly 0.01s
  + walk - returns all files in a nested tree correctly 0.02s
  + writeRotate 0.07s
  + isDirectory - returns false if the path is for a file 0.00s
  + isDirectory - returns true if the path is for a directory 0.00s
  + isFile - returns true if the path is for a file 0.00s
  + isFile - returns false if the path is for a directory 0.00s
fs2.io.file.PathSuite:
  + construction 0.00s
  + normalize 0.00s
  + fileName 0.00s
  + parent 0.00s
  + isAbsolute 0.00s
  + / 0.00s
  + relativize 0.00s
  + resolve 0.00s
  + extName 0.00s
  + startsWith/endsWith 0.04s
  + Monoid[Path]: monoid.associative 0.01s
  + Monoid[Path]: monoid.collect0 0.00s
  + Monoid[Path]: monoid.combine all 0.17s
  + Monoid[Path]: monoid.combineAllOption 0.14s
  + Monoid[Path]: monoid.intercalateCombineAllOption 0.05s
  + Monoid[Path]: monoid.intercalateIntercalates 0.01s
  + Monoid[Path]: monoid.intercalateRepeat1 0.00s
  + Monoid[Path]: monoid.intercalateRepeat2 0.01s
  + Monoid[Path]: monoid.is id 0.00s
  + Monoid[Path]: monoid.left identity 0.00s
  + Monoid[Path]: monoid.repeat0 0.00s
  + Monoid[Path]: monoid.repeat1 0.00s
  + Monoid[Path]: monoid.repeat2 0.00s
  + Monoid[Path]: monoid.reverseCombineAllOption 0.08s
  + Monoid[Path]: monoid.reverseRepeat1 0.00s
  + Monoid[Path]: monoid.reverseRepeat2 0.00s
  + Monoid[Path]: monoid.reverseReverses 0.00s
  + Monoid[Path]: monoid.right identity 0.00s
  + Order[Path]: order.antisymmetry 0.00s
  + Order[Path]: order.antisymmetry eq 0.00s
  + Order[Path]: order.compare 0.00s
  + Order[Path]: order.gt 0.00s
  + Order[Path]: order.gteqv 0.01s
  + Order[Path]: order.lt 0.00s
  + Order[Path]: order.max 0.00s
  + Order[Path]: order.min 0.00s
  + Order[Path]: order.partialCompare 0.01s
  + Order[Path]: order.pmax 0.01s
  + Order[Path]: order.pmin 0.00s
  + Order[Path]: order.reflexivity eq 0.00s
  + Order[Path]: order.reflexivity gt 0.00s
  + Order[Path]: order.reflexivity lt 0.00s
  + Order[Path]: order.symmetry eq 0.01s
  + Order[Path]: order.totality 0.00s
  + Order[Path]: order.transitivity 0.01s
  + Order[Path]: order.transitivity eq 0.01s
  + Hash[Path]: hash.antisymmetry eq 0.00s
  + Hash[Path]: hash.hash compatibility 0.01s
  + Hash[Path]: hash.reflexivity eq 0.00s
  + Hash[Path]: hash.same as scala hashing 0.01s
  + Hash[Path]: hash.same as universal hash 0.01s
  + Hash[Path]: hash.symmetry eq 0.00s
  + Hash[Path]: hash.transitivity eq 0.01s
fs2.io.net.udp.UdpSuite:
  + udp - echo one 0.04s
  + udp - echo lots 2.89s
fs2.io.net.tcp.SocketSuite:
  + tcp - echo requests - each concurrent client gets back what it sent 0.33s
  + tcp - readN yields chunks of the requested size 0.06s
  + tcp - write - concurrent calls do not cause a WritePendingException 0.19s
  + tcp - addresses - should match across client and server sockets 0.03s
scala.scalajs.js.JavaScriptException: Error: getaddrinfo ENOTFOUND not.example.com
  at GetAddrInfoReqWrap.onlookup [as oncomplete](node:dns:71:26)
  + tcp - errors - should be captured in the effect 0.13s
  + tcp - options - should work with socket options 0.04s
fs2.io.net.unixsocket.UnixSocketsSuite:
  + echoes - node.js 2.31s
fs2.io.NodeJSCompressionSuite:
  + deflate input 0.24s



  | => ioJS / Test / executeTests 111s

}

test("inflate input") {
test("inflate input".ignore) { // TODO: This test hangs after upgrading to latest scalacheck-effect release, which fixed generators to increase sizes

@mpilquist mpilquist Oct 3, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armanbilge I haven't looked in to why yet but this test hangs (and doesn't even timeout) when run against the new scalacheck-effect. The only difference should be that the string parameter grows to be more than 1 character long now.

@armanbilge armanbilge Oct 3, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just on JS I assume? I remember having some problems if the inputs got too big but that doesn't seem to be the case here. I'll look into it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, only hangs on JS - passed on JVM.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait I misread that. I saw this PR to scalacheck-effect. So actually the inputs were only 1-character long all along?

@mpilquist
mpilquist merged commit d955f69 into typelevel:main Oct 6, 2021
@mpilquist
mpilquist deleted the topic/upgrade-scalacheck-effect branch February 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants