Re-worked Node.js readReadable API - #2663
Merged
Merged
Conversation
armanbilge
changed the title
readReadable APIreadReadable API
armanbilge
commented
Oct 4, 2021
Comment on lines
+67
to
+72
| // Implementation Note: why suspend in `SyncIO` and then `unsafeRunSync()` inside `F.delay`? | ||
| // In many cases creating a `Readable` starts async side-effects (e.g. negotiating TLS handshake or opening a file handle). | ||
| // Furthermore, these side-effects will invoke the listeners we register to the `Readable`. | ||
| // Therefore, it is critical that the listeners are registered to the `Readable` _before_ these async side-effects occur: | ||
| // in other words, before we next yield (cede) to the event loop. Because an arbitrary effect `F` (particularly `IO`) may cede at any time, | ||
| // our only recourse is to suspend the entire creation/listener registration process within a single atomic `delay`. |
armanbilge
marked this pull request as ready for review
October 4, 2021 03:35
Member
Author
|
I'd really appreciate some critical eyes on this. These methods for translating between Node.js and fs2 Streams are at the heart of all the implementations (Sockets, TLS, files). So it's really important to get this right. |
armanbilge
changed the title
readReadable APIreadReadable API
Member
Author
|
I |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far this fixes the issue reported in #2661, but I think the API for converting a Node.js
Readablestream into aStreamof bytes is still unsafe. I have another idea I want to try.