Add tlMimaPreviousVersions setting#176
Conversation
danicheg
left a comment
There was a problem hiding this comment.
Sorry for being late on this. Here are my 2 cents on the topic. Wouldn't that be confusing for users to deal with the settings behaving likewise the upstream settings? Say, the tlFoo setting where foo comes from an upstream library. An ability to configure things at the build/project level multiple ways increases entropy, I guess. Moreover, if new tl-* settings would slightly differ in behavior against original upstream settings, then it really can be hard to figure out things.
|
@danicheg thanks for your feedback, always much much appreciated! I guess you are talking about the difference between The problem is that I agree that it is confusing, and I would like to make this better though. WDYT? |
|
Nevermind. I'm just overthinking about corner cases, probably. sbt-typelevel can mitigate some difficulties of configuring plugins for their users. As you said, users might be wrong on it also without sbt-typelevel. |
|
FWIW I expect this setting to be rarely used. Of all the Typelevel projects, really only Cats and Scalacheck seem to need it. |
|
Darn, this PR introduced a regression. |
We previously debated its usefulness in #46, but now I'm convinced.
mimaPreviousArtifactsis at the project level, but often you want to filter botched releases at the build-level.tlMimaPreviousVersionsis build-level.So yeah, I'm convinced :)