Skip to content

Add tlCursedVersions setting - #46

Closed
armanbilge wants to merge 3 commits into
typelevel:mainfrom
armanbilge:feature/cursed-versions
Closed

Add tlCursedVersions setting#46
armanbilge wants to merge 3 commits into
typelevel:mainfrom
armanbilge:feature/cursed-versions

Conversation

@armanbilge

Copy link
Copy Markdown
Member

For excluding mucked up or otherwise unpublished versions from mima checks. We've all been there. (Name subject to bikeshed.)

@rossabaker

Copy link
Copy Markdown
Member

I usually just run my own filterNot on these, which can additionally target specific Scala versions. I don't have an objection to it, but I don't know that the setting adds much here.

@armanbilge

Copy link
Copy Markdown
Member Author

That's a good point. I think the filterNot on mimaPreviousArtifacts is slightly more tedious because it's a set of module IDs and not versions. In any case I'm happy to let this sit and see if anyone really wants it.

@armanbilge

Copy link
Copy Markdown
Member Author

Maybe the setting we are actually missing is a tlPreviousVersions, that is auto-populated by our plugin and then can be introspected/modified by the user.

@rossabaker

Copy link
Copy Markdown
Member

In that world, is tlVersionIntroduced still useful? I guess it helps people avoid filtering on an ordering of whatever semver representation is settled on.

@armanbilge

Copy link
Copy Markdown
Member Author

I've migrated a lot of builds and this hasn't come up. Happy to revisit if someone wants it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants