Skip to content

tests(cg): regular Kokkos exec space instances#150

Merged
romintomasetti merged 1 commit into
mainfrom
cg-regular
Apr 24, 2025
Merged

tests(cg): regular Kokkos exec space instances#150
romintomasetti merged 1 commit into
mainfrom
cg-regular

Conversation

@romintomasetti

@romintomasetti romintomasetti commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Summary

Lay the groundwork for a CG implementation with graph.

Related to

Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/test_regular.cpp Outdated
Comment thread tests/cg/test_regular.cpp Outdated
Comment thread tests/cg/test_regular.cpp
Comment thread tests/cg/test_regular.cpp
Comment thread tests/cg/test_regular.cpp
Comment thread tests/cg/test_regular.cpp Outdated
Comment thread tests/cg/test_regular.cpp Outdated

@maartenarnst maartenarnst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Got to the end! Mostly details. There's the issue of having a container class + create function for the test problem. And we'll have to take a look at the "dot type" / "mag type" types.

@romintomasetti romintomasetti force-pushed the cg-regular branch 10 times, most recently from 71eb726 to 0dae8e2 Compare April 22, 2025 08:50
@romintomasetti romintomasetti changed the title tests(cg): regular kokkos exec space instances tests(cg): regular Kokkos exec space instances Apr 23, 2025
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
@romintomasetti

Copy link
Copy Markdown
Collaborator Author

@maartenarnst OK to merge ?

Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp
Comment thread tests/cg/Helpers.hpp Outdated
Comment thread tests/cg/Helpers.hpp
Comment thread tests/cg/test_regular.cpp

@maartenarnst maartenarnst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 🟢

@romintomasetti romintomasetti merged commit f891bdd into main Apr 24, 2025
@romintomasetti romintomasetti deleted the cg-regular branch April 24, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants