tests(cg): use Kokkos::Graph#154
Merged
Merged
Conversation
romintomasetti
force-pushed
the
cg-graph
branch
5 times, most recently
from
c291ddf to
30d5c16
Compare
romintomasetti
commented
Apr 25, 2025
romintomasetti
force-pushed
the
cg-graph
branch
2 times, most recently
from
6eddcc8 to
5de7348
Compare
Collaborator
Author
|
@maartenarnst I need uliegecsm/kokkos-utils#48 to make it better. |
romintomasetti
force-pushed
the
cg-graph
branch
3 times, most recently
from
b67238b to
254011e
Compare
romintomasetti
commented
May 7, 2025
romintomasetti
force-pushed
the
cg-graph
branch
2 times, most recently
from
d52b30d to
084b5c9
Compare
romintomasetti
force-pushed
the
cg-graph
branch
5 times, most recently
from
4f307e8 to
0f56808
Compare
romintomasetti
force-pushed
the
cg-graph
branch
2 times, most recently
from
b00057a to
2e48d59
Compare
romintomasetti
force-pushed
the
cg-graph
branch
2 times, most recently
from
7d95136 to
0829d66
Compare
romintomasetti
force-pushed
the
cg-graph
branch
3 times, most recently
from
9e0a697 to
5449050
Compare
Merged
romintomasetti
force-pushed
the
cg-graph
branch
10 times, most recently
from
1151b88 to
c312cfe
Compare
maartenarnst
reviewed
Jul 3, 2025
maartenarnst
reviewed
Jul 3, 2025
maartenarnst
reviewed
Jul 3, 2025
maartenarnst
reviewed
Jul 3, 2025
maartenarnst
reviewed
Jul 3, 2025
maartenarnst
reviewed
Jul 3, 2025
Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tries to build the CG algorithm from #150 with
Kokkos::Graph.Description
For now, there are many restrictions / issues.
For instance, I cannot use
KokkosSparse::spmvfor the following reasons:Kokkosnode. Adding successors is hard.KokkosSparse::spmvis not graph-compatible because it computes/create stuff that will eventually not persist (descriptors and what not). Wrapper aKokkosSparse::spmvin apred.cuda_captureis a guaranteed highway to hell.Related to
Kokkosexec space instances #150