tests(cg): use custom math kernels instead of KokkosKernels free functions#163
Merged
Conversation
romintomasetti
force-pushed
the
cg-reg-no-tpl
branch
4 times, most recently
from
c662236 to
4eddf9a
Compare
romintomasetti
force-pushed
the
cg-reg-no-tpl
branch
from
4eddf9a to
6848bf8
Compare
romintomasetti
force-pushed
the
cg-reg-no-tpl
branch
from
6848bf8 to
cb985fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the "regular" CG routine, but using custom math kernels.
These kernels are heavily inspired by or reuse
KokkosKernels, but can be enqueued in a graph.Using
KokkosKernelsfree functions directly within a graph is either impossible or bug prone.Related to