Skip to content

ExecutionSpace: OpState and ParallelFor#347

Merged
romintomasetti merged 1 commit into
mainfrom
opstate5
Feb 17, 2026
Merged

ExecutionSpace: OpState and ParallelFor#347
romintomasetti merged 1 commit into
mainfrom
opstate5

Conversation

@maartenarnst

Copy link
Copy Markdown
Collaborator

This PR:

  • introduces an OpState class that can create and start a Kokkos parallel region as a child operation
  • uses this class in a parallel_for algorithm that is customised for the execution space domain

WIP :)

Extracted from:

Working towards:

@romintomasetti romintomasetti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have a few files to go over.

Comment thread tests/kokkos_ext/execution_space/test_operation_state.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_operation_state.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_operation_state.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_operation_state.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp
Comment thread kokkos_ext/impl/execution_space/then.hpp
Comment thread kokkos_ext/impl/execution_space/then.hpp
Comment thread kokkos_ext/impl/execution_space/operation_state.hpp
Comment thread kokkos_ext/impl/execution_space/operation_state.hpp Outdated
Comment thread kokkos_ext/impl/execution_space/operation_state.hpp Outdated
Comment thread kokkos_ext/impl/execution_space/operation_state.hpp Outdated
Comment thread kokkos_ext/impl/execution_space/operation_state.hpp Outdated
Comment thread kokkos_ext/impl/execution_space/parallel_for.hpp Outdated
Comment thread kokkos_ext/impl/execution_space/parallel_for.hpp Outdated
Comment thread kokkos_ext/impl/parallel_for.hpp Outdated
Comment thread kokkos_ext/impl/parallel_for.hpp Outdated
Comment thread kokkos_ext/impl/parallel_for.hpp Outdated
@maartenarnst maartenarnst force-pushed the opstate5 branch 4 times, most recently from b952fcd to 7bb0cea Compare February 11, 2026 16:58
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
Comment thread tests/kokkos_ext/execution_space/test_parallel_for.cpp Outdated
@maartenarnst

Copy link
Copy Markdown
Collaborator Author

The exec_policy_t could become just policy_t.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread kokkos_ext/impl/execution_space/operation_state.hpp Outdated
Comment thread tests/kokkos_ext/execution_space/CMakeLists.txt Outdated
Comment thread tests/kokkos_ext/execution_space/test_then.cpp Outdated
Comment thread kokkos_ext/impl/execution_space/parallel_for.hpp Outdated
Signed-off-by: Maarten Arnst <maarten.arnst@uliege.be>
Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>

@romintomasetti romintomasetti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

@romintomasetti romintomasetti merged commit 84d94fd into main Feb 17, 2026
16 checks passed
@romintomasetti romintomasetti deleted the opstate5 branch February 17, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants