Skip to content

feat: liquidator query enabled by runtime flag#1577

Merged
mergify[bot] merged 12 commits intomainfrom
adam/flaggo
Nov 14, 2022
Merged

feat: liquidator query enabled by runtime flag#1577
mergify[bot] merged 12 commits intomainfrom
adam/flaggo

Conversation

@toteki
Copy link
Copy Markdown
Contributor

@toteki toteki commented Nov 11, 2022

Description

The query liquidation-targets is enabled at runtime the node is started with a flag:

# Enabled
umeed start --enable-liquidator-query

# Enabled
umeed start -l

# Disabled
umeed start

closes: #1400


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki marked this pull request as ready for review November 11, 2022 14:29
@toteki toteki requested review from a team as code owners November 11, 2022 14:29
Copy link
Copy Markdown
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid the global variables, especially if we modify them in tests, and even more especially if they are pointers.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1577 (c1115dd) into main (56b89e0) will increase coverage by 0.10%.
The diff coverage is 68.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
+ Coverage   52.08%   52.18%   +0.10%     
==========================================
  Files          72       73       +1     
  Lines        7092     7105      +13     
==========================================
+ Hits         3694     3708      +14     
+ Misses       3125     3124       -1     
  Partials      273      273              
Impacted Files Coverage Δ
x/leverage/module.go 56.92% <0.00%> (-1.81%) ⬇️
x/oracle/types/keys.go 45.71% <0.00%> (+3.60%) ⬆️
util/bytes.go 100.00% <100.00%> (ø)
x/leverage/keeper/grpc_query.go 64.17% <100.00%> (ø)
x/oracle/keeper/historic_price.go 93.93% <100.00%> (+0.12%) ⬆️

Copy link
Copy Markdown
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. LGTM.

toteki and others added 3 commits November 14, 2022 11:47
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@mergify mergify bot merged commit 60f7da4 into main Nov 14, 2022
@mergify mergify bot deleted the adam/flaggo branch November 14, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation about liquidation_targets query

3 participants