Conversation
|
imo this is the cleaner way to go. |
|
@toteki after this PR is merged will we be g2g on the gravity bridge upgrade? |
|
This and #1577 yeah |
|
I'm going sleep now. Personally i think it's better to add the fix rather then doing 3 similar commits (old push, this revert, and the new re-push with fix). Of course this only make sense if we are not under big pressure.l, and i already have most of the gov message part done. Need to update CLI . |
|
That being said I'm not against revert and redo if others support it. |
robert-zaremba
left a comment
There was a problem hiding this comment.
As noted in other comment, we don't need to go back and forth with these proto changes. So blocking it because these are unnecessary back-and-forth changes.
I've prepared a migration: #1593
still need to test it.
The full migration to go out of the param space is a bit more complex, so will be better to do it in v3.3
Description
First step of #1585 - second would be re-enabling.
I think this is a cleaner path to
v3.2.0release than leavingmainbranch incompatible or building a migration to put the params in early.