Disallow TS integration on network types host/container

[Squidly271]

Summary by CodeRabbit

• New Features
  • Improved the Docker container configuration interface so that advanced service settings are displayed only when applicable—Tailscale options now automatically appear for supported network selections and are hidden for others, streamlining the configuration process for a clearer user experience.

[coderabbitai]

Walkthrough

This update modifies the Docker container configuration interface to conditionally handle Tailscale options. The changes add logic to disable the Tailscale checkbox and hide related settings when the network type is set to "host" or "container." For "bridge" or "custom" network types, the Tailscale options are displayed. The modifications include new div elements and adjustments to JavaScript functions (showSubnet and showTailscale) to manage these behaviors appropriately.

Changes

File	Change Summary
emhttp/.../CreateDocker.php	Added conditional logic to disable the Tailscale checkbox and hide/show Tailscale settings based on the selected network type. Updated JavaScript functions accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant UI as Web Interface
    participant JS as JavaScript Functions
    U->>UI: Selects network type (bridge/custom or host/container)
    UI->>JS: Trigger network type change
    alt Network type is "bridge" or "custom"
        JS-->>UI: Show Tailscale options and enable checkbox
    else Network type is "host" or "container"
        JS-->>UI: Hide Tailscale options and uncheck checkbox
    end

Loading

Possibly related PRs

• Wireless support - fine tuning #2002: Introduced similar conditional logic for network interface handling, particularly for wireless interfaces, which has parallels to the Tailscale configuration changes here.

Poem

In a world of code so neat,
A rabbit hops with lively feet.
Tailscale options wink or hide,
With network types set side by side.
Hop along, let logic dance—
In Docker’s realm, we seize our chance!
🐇💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9126eb4 and bae5b51.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix.docker.manager/include/CreateDocker.php (3 hunks)

🔇 Additional comments (3)

emhttp/plugins/dynamix.docker.manager/include/CreateDocker.php (3)

1156-1170: LGTM! Clear separation of UI states for different network types.

The implementation correctly adds two separate div elements to handle Tailscale UI visibility:

• TSNetworkAllowed: Shows Tailscale options for bridge/custom networks
• TSNetworkNotAllowed: Shows disabled message for host/container networks

---

1545-1553: LGTM! Network type restrictions are properly enforced.

The code correctly:

1. Disables and unchecks Tailscale checkbox for host/container networks
2. Toggles visibility of appropriate UI elements based on network type

---

1704-1709: LGTM! Additional network type validation in showTailscale.

The function adds an extra layer of validation to ensure Tailscale remains disabled for host/container networks, even if the user tries to enable it through other means.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.