Refactor: Disallow TS on Host/Container Networks

[Squidly271]

Summary by CodeRabbit

• Refactor
  • Streamlined the behavior of network configuration controls. Toggle elements now update their state more directly, resulting in smoother and more consistent visual feedback during configuration adjustments.

[coderabbitai]

Walkthrough

The changes simplify how the #contTailscale checkbox is manipulated in the showSubnet and showTailscale functions in the CreateDocker.php file. The previous method used chained calls (including .click(), .switchButton(), and .prop()) to update both the checkbox state and its visual appearance. The update now directly sets the checkbox’s state with .prop('checked', false) and, in one instance, triggers a click on a sibling element for visual update. No changes were made to public entity declarations.

Changes

File	Changes Summary
emhttp/.../CreateDocker.php	showTailscale: Removed chained calls (e.g., .click(), .switchButton()) and now directly sets the checkbox state with .prop('checked', false). showSubnet: Replaced a .switchButton() method call with triggering the sibling element via .siblings('.switch-button-background').click() to update the UI.

Possibly related PRs

• Disallow TS integration on network types host/container #2024: This PR also modifies JavaScript functions related to Tailscale settings, indicating a strong code-level connection with the changes made here.

Poem

I'm a rabbit, hopping through code,
Nibbling bugs as they lighten my load.
Checkbox tweaks now clear and bright,
Simplified clicks make my heart delight.
Hoppin' happily into a smoother night! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

emhttp/plugins/dynamix.docker.manager/include/CreateDocker.php (2)

1555-1555: Improve the checkbox state update in showSubnet.

The current implementation uses jQuery's .click() on the switch button background element to update the visual state. Consider using the more direct .switchButton('option', 'checked', false) method instead, which is the recommended way to programmatically update a jQuery UI switch button.

-    $('#contTailscale').siblings('.switch-button-background').click();
+    $('#contTailscale').switchButton('option', 'checked', false);

---

1716-1716: Simplify the checkbox state update in showTailscale.

The code directly sets the checkbox's checked property to false. This is a cleaner approach compared to the previous chained calls, but it should be accompanied by a visual update of the switch button.

Consider adding the visual update:

     $('#contTailscale').prop('checked',false);
+    $('#contTailscale').switchButton('option', 'checked', false);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 010ad20 and 8f1bf83.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix.docker.manager/include/CreateDocker.php (2 hunks)