Skip to content

Chore: Prevent unraid.patch (original) from installing on 7.1.0+#2062

Merged
limetech merged 3 commits into
unraid:masterfrom
Squidly271:patch-35
Mar 21, 2025
Merged

Chore: Prevent unraid.patch (original) from installing on 7.1.0+#2062
limetech merged 3 commits into
unraid:masterfrom
Squidly271:patch-35

Conversation

@Squidly271

@Squidly271 Squidly271 commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Revised the system’s plugin management during startup.
    • Updated the classification of obsolete plugins and adjusted the prioritized list to enhance initialization efficiency.

@coderabbitai

coderabbitai Bot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes update the etc/rc.d/rc.local script to modify plugin handling during system initialization. The OBSOLETE variable now includes unraid.patch and AAA-UnraidPatch-BootLoader-DO_NOT_DELETE, marking them as obsolete. Meanwhile, the PRIORITY_PLUGINS array has been adjusted to remove unraid.patch.plg, leaving only dynamix.unraid.net.plg as the high-priority plugin. These modifications affect how the system categorizes and processes plugins at startup.

Changes

File Change Summary
etc/rc.d/rc.local - Added unraid.patch and AAA-UnraidPatch-BootLoader-DO_NOT_DELETE to OBSOLETE list.
- Removed unraid.patch.plg from PRIORITY_PLUGINS, retaining dynamix.unraid.net.plg.

Sequence Diagram(s)

sequenceDiagram
    participant System
    participant RC_Local
    participant PluginManager

    System->>RC_Local: Start system initialization
    RC_Local->>PluginManager: Validate OBSOLETE plugins list (includes unraid.patch and AAA-UnraidPatch-BootLoader-DO_NOT_DELETE)
    RC_Local->>PluginManager: Load priority plugins (dynamix.unraid.net.plg)
    PluginManager-->>RC_Local: Confirm plugin configurations
    RC_Local->>System: Complete startup process
Loading

Possibly related PRs

  • feat: install priority plugins first #1997: The changes in the main PR modify the PRIORITY_PLUGINS variable by removing unraid.patch.plg, while the retrieved PR introduces this variable and includes unraid.patch.plg, indicating a direct relationship in how plugins are prioritized during installation.

Poem

Oh, I'm a rabbit, hopping light and free,
Cleaning up plugins methodically.
Unraid.patch is set aside,
Letting new priorities be our guide.
A startup dance, as swift as can be!
🐰🎶


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between e499fd9 and ce5b652.

📒 Files selected for processing (1)
  • etc/rc.d/rc.local (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • etc/rc.d/rc.local

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment thread etc/rc.d/rc.local Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants