fix: obsolete the patch plugin quietly

[ljm42]

the standalone patch plugin is not needed on this release

Summary by CodeRabbit

• New Features

  • Enhanced handling of obsolete plugins by streamlining their removal and improving the cleanup process for leftover plugin files.

• Chores

  • Reduced unnecessary logging, ensuring that plugins flagged for quiet removal are processed efficiently without extra log entries.

[coderabbitai]

Walkthrough

The changes update the etc/rc.d/rc.local script by introducing a new variable QUIET that specifies plugins to be removed without logging. The logic now checks if a plugin exists in the QUIET list: if it does, it is removed directly; otherwise, a log is created, and the plugin is moved to an error directory. Additionally, a cleanup loop has been added to remove any leftover .plg files from previous runs. Minor modifications to the quoting of variables in conditionals and file operations have also been implemented.

Changes

File	Change Summary
etc/rc.d/rc.local	- Added QUIET variable for plugins set to be removed quietly - Modified obsolete plugin handling to conditionally log and move plugins - Added cleanup loop for leftover .plg files - Improved quoting of variables in conditionals and file operations

Sequence Diagram(s)

sequenceDiagram
    participant Script
    participant Plugin
    participant Log
    Script->>Script: Check if plugin is in QUIET list
    alt Plugin is in QUIET
        Script->>Script: Remove plugin without logging
    else Plugin is NOT in QUIET
        Script->>Log: Log plugin movement to error directory
        Script->>Script: Move plugin to error directory
    end
    Script->>Script: Execute cleanup loop to remove leftover .plg files

Loading

Possibly related PRs

• Chore: Prevent unraid.patch (original) from installing on 7.1.0+ #2062: Updates the OBSOLETE variable to include plugins, complementing the new behavior in this PR by aligning plugin management logic.

Suggested Reviewers

• elibosley

Poem

In the code garden, I gently roam,
Removing plugins, making errors their home.
With QUIET in hand, no noisy display,
I hop through scripts, brightening the day.
A bunny’s delight in every line I comb! 🐰

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b60144 and b9607c9.

📒 Files selected for processing (1)

• etc/rc.d/rc.local (1 hunks)

🔇 Additional comments (3)

etc/rc.d/rc.local (3)

94-94: Well-defined QUIET variable for silent plugin removal

The new QUIET variable clearly identifies plugins that should be removed without logging or notification. This is a good approach as it allows for easy management of which plugins should be quietly obsoleted.

The inclusion of "unraid.patch" and "AAA-UnraidPatch-BootLoader-DO_NOT_DELETE" aligns with the PR objective to obsolete the patch plugin quietly.

---

97-119: Improved plugin handling logic with better path safety

The updated conditional logic now properly handles quiet and normal obsolete plugins differently. The code correctly:

1. Uses quoted variables throughout for proper path handling
2. Checks if plugins are in the QUIET list before deciding how to handle them
3. Removes quiet plugins directly instead of moving them to the error directory
4. Properly logs only non-quiet plugin movements

This approach successfully implements the "quiet" removal of the patch plugin as intended.

---

121-126: Good cleanup logic for previously moved quiet plugins

This cleanup loop ensures any quiet plugins that might have been moved to the plugins-error directory in previous runs are also removed. This is a thorough approach that handles the transition cleanly by removing historical artifacts.

The implementation is complete and properly handles the cleanup requirement.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.