Wireless: fix PHP errors with manual network adding

[bergware]

Summary by CodeRabbit

• Bug Fixes
  • Improved the system’s stability by ensuring smoother handling of attribute values, helping to prevent unexpected errors during operation.

[coderabbitai]

Walkthrough

This change updates the saveAttr function in a PHP file so that attributes (ATTR1, ATTR2, and ATTR3) are retrieved from an array using the null coalescing operator. This ensures that if the keys are missing, a default empty string is provided, preventing undefined index notices.

Changes

File(s)	Change Summary
emhttp/plugins/.../Wireless.php	Modified saveAttr to use the null coalescing operator (??) for ATTR1, ATTR2, and ATTR3 retrieval.

Possibly related PRs

• Network: fix regression errors #2051: Modified the saveAttr function in Wireless.php using the null coalescing operator to handle potential undefined index issues for attributes, aligning closely with the current changes.

Poem

I'm a code bunny, hopping through lines so neat,
Fixing bugs with a skip and a joyful beat.
Default values here and there, code now shines so bright,
With ?? by my side, errors fade out of sight.
Hoppin' and cloppin', our code now feels just right!
🐇💻

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62a5152 and 9d61441.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/Wireless.php (1 hunks)

🔇 Additional comments (1)

emhttp/plugins/dynamix/include/Wireless.php (1)

152-154: Good fix for preventing undefined index notices.

The use of the null coalescing operator (??) here is an excellent way to handle potentially missing array keys in the $attr[$ssid] array. This change will prevent PHP "Undefined array key" notices when manually adding networks where these attributes might not be defined in the array.

This is exactly what the PR title promised - fixing PHP errors with manual network adding - and the implementation is clean and effective.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.