Wireless and style fixes

[bergware]

Summary by CodeRabbit

• Refactor

  • Enhanced WiFi scanning to process network data more flexibly and correctly identify open networks.
  • Refined logic for displaying network information based on security settings for more accurate visibility.

• Style

  • Adjusted text area dimensions and updated element styling for a more consistent layout.
  • Introduced new spacing rules to improve the overall readability of the interface.

[coderabbitai]

Walkthrough

This pull request updates two components. In the PHP file, modifications to the scanWifi and saveAttr functions refine the logic for handling WiFi scanning details and adjust attribute visibility based on security checks. In the CSS file, changes adjust element widths and add new styling rules for specific selectors. No changes were made to exported or public entities.

Changes

File	Change Summary
emhttp/.../Wireless.php	Updated scanWifi to allow four attributes unless 'Authentication suites:' is present; auto-assigns 'open' to networks lacking a fifth attribute. Refined visibility conditions in saveAttr by including additional checks for security states.
emhttp/.../Syslinux.css	Reduced .raw textarea width from 65.5% to 63% and added new styles for span.array, span.system, and textarea.menu with fixed 63% width and !important override; introduced a left padding of 40px for dd elements.

Sequence Diagram(s)

sequenceDiagram
    participant S as Scanner
    participant F as scanWifi
    participant C as Condition Check
    participant R as Result Handler
    S->>F: Initiate WiFi scan
    F->>C: Check attribute count and 'Authentication suites:' presence
    C-->>F: Validation result
    alt Open network detected
        F->>F: Assign 'open' to attribute if missing
    end
    F->>R: Return processed WiFi data

Loading

sequenceDiagram
    participant U as User Action
    participant F as saveAttr
    participant C0 as $hide0 Check
    participant C1 as $hide1 Check
    participant V as Visibility Update
    U->>F: Trigger attribute save
    F->>C0: Evaluate visibility ($hide0) ensuring security ≠ 'auto'
    C0-->>F: Condition result
    F->>C1: Evaluate visibility ($hide1) with security and attribute state
    C1-->>F: Condition result
    F->>V: Apply final visibility settings to UI elements

Loading

Possibly related PRs

• Wireless: fix potential double entries in station list #2084: Adjustments in the WiFi scanning and attribute assignment logic are similar to the changes made in this pull request.
• Network: fix regression errors #2051: Contains modifications in the saveAttr function, focusing on attribute handling logic.
• Wireless: fix PHP errors with manual network adding #2064: Involves changes to attribute processing in Wireless.php, directly relating to the enhancements in visibility management.

Poem

I'm a bunny hopping through the code,
Scanning WiFi with a refined mode,
Attributes now dance with checks so mild,
Styling tweaks make the interface wild,
A rabbit's joy in every line bestowed!
🐇💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 828f7ef and 10724e8.

📒 Files selected for processing (2)

• emhttp/plugins/dynamix/include/Wireless.php (2 hunks)
• emhttp/plugins/dynamix/sheets/Syslinux.css (1 hunks)

🔇 Additional comments (4)

emhttp/plugins/dynamix/include/Wireless.php (3)

42-42: Improved WiFi scanning logic to handle Authentication suites better.

The condition has been enhanced to allow rows with exactly 4 attributes if they contain 'Authentication suites:', which was previously being skipped as incomplete information. This will ensure that networks with authentication information are properly recognized during scanning.

---

50-51: Good addition for identifying open networks.

Adding explicit identification for open networks ensures proper categorization when networks don't specify their security type. This helps with accurate representation in the UI and simplifies conditional logic elsewhere in the code.

---

166-172: Enhanced visibility conditions for WiFi security options.

The visibility conditions have been refined to better handle different security scenarios:

1. $hide0 now accounts for both manual entry, IEEE security types, and the 'auto' security mode
2. $hide1 now properly hides password fields for open networks and when attributes aren't defined

These changes will ensure that the appropriate form fields are displayed or hidden based on the network's security configuration.

emhttp/plugins/dynamix/sheets/Syslinux.css (1)

3-5: Improved element width consistency and spacing.

The styling changes ensure consistent width (63%) across multiple element types and add proper padding for definition lists:

1. Reduced textarea.raw width to 63% for better proportions
2. Added consistent width for span.array, span.system, and textarea.menu elements with !important to ensure styling priority
3. Added left padding to dd elements for better visual hierarchy and readability in definition lists

These changes will improve the overall UI layout and element alignment.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.