Docker and VM: remove "path does not exist" warning#2168
Merged
Conversation
Contributor
## Walkthrough
The changes simplify the warning logic in the Docker and VM settings pages by removing conditional checks and warnings related to the existence of directory paths. Now, the only warning displayed is when the array is not started, eliminating previous checks for whether specific paths exist. Additionally, in the VM settings page, copyright years were updated, and PHP conditional blocks were reformatted for clarity. In the WireGuard update script, the method for retrieving network interface and IP details was changed from parsing a static ini file to using dynamic system commands, alongside comprehensive code style and spacing improvements. Function signatures were adjusted for spacing and the removal of a parameter in `thisNet()`. No changes were made to exported or public entities beyond these signature formatting and parameter adjustments.
## Changes
| File(s) | Change Summary |
|------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------|
| emhttp/plugins/dynamix.docker.manager/DockerSettings.page | Removed conditional checks and warnings for non-existent paths; now only warns if the array is not started. Simplified warning logic for Docker storage driver selection. |
| emhttp/plugins/dynamix.vm.manager/VMSettings.page | Updated copyright years to 2025; reformatted PHP conditional blocks; removed warnings for non-existent paths, leaving only the array-not-started warning. |
| emhttp/plugins/dynamix/include/update.wireguard.php | Refactored `thisNet()` to use system commands instead of ini file parsing for network info; comprehensive code style and spacing improvements; minor function signature spacing adjustments. |
| emhttp/plugins/dynamix/scripts/diagnostics | Removed `log_error()` function; simplified `write()` function to directly publish diagnostics messages; modified `run()` to prepend `LC_ALL=en_US.UTF-8` to commands and removed error logging and return code checks. |
## Possibly related PRs
- unraid/webgui#2163: Also modifies the diagnostics script by updating the `write()` function and command execution, closely related to changes in diagnostics message publishing and locale handling.
- unraid/webgui#2002: Modifies DockerSettings.page with new functions and UI logic for wireless interfaces, related through changes to the same file’s conditional rendering and warnings.
## Poem
> In settings deep where warnings lay,
> The checks for paths have gone away.
> Now only when arrays won’t start,
> A single caution will impart.
> WireGuard’s net now finds its way,
> With cleaner code to save the day.
> 🐇✨📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- make use of "publish" function - force bash commands to run with UTF8 encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit