Docker and VM: remove path do not exist warning

[bergware]

Summary by CodeRabbit

• Refactor
  • Simplified warning messages in Docker and VM settings by removing alerts related to missing directory paths. Now, warnings only appear if the array is not started.
• Style
  • Reduced UI clutter by eliminating unnecessary advanced view toggles linked to missing path warnings.

[coderabbitai]

Walkthrough

This change updates the Docker and VM settings pages by removing conditional logic that previously displayed warnings when specific Docker or VM-related paths did not exist. Now, the only warning shown is when the array is not started, regardless of the existence of the underlying directories. The code is simplified by eliminating checks for path existence and their associated UI elements, resulting in a more streamlined warning display.

Changes

Files	Change Summary
emhttp/plugins/dynamix.docker.manager/DockerSettings.page	Removed warning and conditional logic for missing Docker-related paths; now only warns if array is not started.
emhttp/plugins/dynamix.vm.manager/VMSettings.page	Removed warning and conditional logic for missing VM-related paths; now only warns if array is not started.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsPage
    participant ArrayState

    User->>SettingsPage: Open Docker/VM Settings
    SettingsPage->>ArrayState: Check if array is started
    alt Array not started
        SettingsPage->>User: Show warning: "Docker/VM available after array is started"
    else Array started
        SettingsPage->>User: Show settings (no path existence warnings)
    end

Loading

Possibly related PRs

• Docker and VM: remove "path does not exist" warning #2168: Removes similar conditional warnings about missing Docker and VM directory paths, focusing warning logic on array state rather than path existence.

Poem

In settings deep, where warnings grew,
We’ve trimmed the thorns and let them through.
No more alerts for missing ways—
Just simple words if arrays delay.
The clutter’s gone, the path is clear,
The rabbits hop with less to fear! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d687dce and fb417ce.

📒 Files selected for processing (2)

• emhttp/plugins/dynamix.docker.manager/DockerSettings.page (1 hunks)
• emhttp/plugins/dynamix.vm.manager/VMSettings.page (1 hunks)

🔇 Additional comments (2)

emhttp/plugins/dynamix.vm.manager/VMSettings.page (1)

115-119: Simplified warning logic to remove path existence checks

The change streamlines the UI by removing the conditional warning that was previously displayed when VM-related directories didn't exist. Now, it only shows a warning when the array is not started, which is a more straightforward approach for users.

This change aligns with the similar modification in the Docker settings page, creating a consistent experience across the system.

emhttp/plugins/dynamix.docker.manager/DockerSettings.page (1)

149-151: Simplified warning logic to remove path existence checks

The change removes the conditional warning that was previously shown when Docker-related paths didn't exist. Now, the warning is only displayed when the array is not started, which simplifies the user experience.

This unified approach to warnings creates a more consistent interface across both Docker and VM manager plugins.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.